-
Notifications
You must be signed in to change notification settings - Fork 0
POC for https://github.com/laravel/framework/discussions/31778 excesive set calls for casts #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
macropay-solutions
wants to merge
33
commits into
production
Choose a base branch
from
POC-excesive-set-on-casts
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviusspintican
approved these changes
Nov 2, 2025
…lls during save
…lls during insert also
churkindmitry
approved these changes
Nov 3, 2025
churkindmitry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…model and revert reduce even more the number of set calls during insert also
…model and revert reduce even more the number of set calls during insert also
…model and revert reduce even more the number of set calls during insert also
…model and revert reduce even more the number of set calls during insert also
Owner
Author
|
Deployed these changes to our demo page https://maravelith.laravel-crud-wizard.com/maravelith-10/laravel-lumen-crud-wizard#operations |
$model = User::query()->firstOrFail(); $carbon = $model->date_time_carbon_casted; $carbon->addDay(); echo $model->col_with_get_mutator_that_depends_on_date_time_carbon_casted; // would print 'value date time' without the added day before this commit
…d that got into $original but not in db
…nd backport laravel pull/47450
…cause isDirty will sync/merge the cast cached objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will reduce the number of calls to getDirty during save and also the sync/merge of casted attributes into objects when getAttributeFromArray is called.
Also it will reduce the operation number for update.
Also it will prevent changes in created,updated,saved events from getting into $original without being saved into DB
The only changes that could generate a breaking change are the new properties from HasAttributes trait
related laravel/framework#57627
related discussion laravel/framework#31778
This will allow lock for updates in the model: